Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(udp): add send functionality #272

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 20, 2025

PR Type

  • Improvement

Related Links

Description

This PR adds a send() function to the UDP socket. The function only sends if a send destination address has been set during creation of the socket. Otherwise it throws a UsageError.

All added functionality is covered by unit tests.

Review Procedure

  • Code review
  • Confirm that unit tests cover all provided functionality

Remarks

Clang-tidy was being pedantic in a few spots, so I cleaned up a few of those too.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz February 20, 2025 01:43
@mojomex mojomex self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.

Project coverage is 28.10%. Comparing base (78d4fb9) to head (570b2bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   29.28%   28.10%   -1.18%     
==========================================
  Files         112      112              
  Lines        9733     9642      -91     
  Branches     3252     2668     -584     
==========================================
- Hits         2850     2710     -140     
- Misses       6359     6452      +93     
+ Partials      524      480      -44     
Flag Coverage Δ
differential 28.10% <89.87%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 39.78% <89.87%> (-10.46%) ⬇️
Hesai 29.25% <ø> (-1.16%) ⬇️
Velodyne 37.11% <ø> (-0.08%) ⬇️
Continental 24.93% <ø> (-0.13%) ⬇️
Robosense 0.00% <ø> (ø)

@mojomex mojomex mentioned this pull request Feb 20, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant