Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ars548): use new UDP socket #273

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 20, 2025

PR Type

  • Improvement

Related Links

Description

⚠️ #272 has to be merged first,after which this PR has to be rebased ⚠️

Introduce the new UDP socket to the ARS548 hardware interface. This

Review Procedure

Test with a real sensor if all data is sent/received as expected.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 65.13761% with 38 lines in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (8d6aec1) to head (30443dc).

Files with missing lines Patch % Lines
..._hw_interfaces/continental_ars548_hw_interface.cpp 0.00% 30 Missing ⚠️
...es/nebula_hw_interfaces_common/connections/udp.hpp 84.61% 0 Missing and 4 partials ⚠️
nebula_hw_interfaces/test/common/test_udp.cpp 92.68% 0 Missing and 3 partials ⚠️
...ebula_hw_interfaces/test/common/test_udp/utils.hpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   29.28%   28.22%   -1.07%     
==========================================
  Files         112      112              
  Lines        9733     9603     -130     
  Branches     3252     2657     -595     
==========================================
- Hits         2850     2710     -140     
- Misses       6359     6414      +55     
+ Partials      524      479      -45     
Flag Coverage Δ
differential 28.22% <65.13%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25
Copy link
Collaborator

knzo25 commented Feb 28, 2025

@mojomex
Tested on the bench by launching the radars.launch independently
Checked rates and contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants