Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): update launch files to match new autoware universe package naming #27

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Sep 5, 2024

PR Type

  • Improvement

Description

This PR updates the edge_auto_launch launch files to match the new autoware naming scheme introduced in version 2024.07.

Follows the review on #26

Review Procedure

Launch the system as usual following the README instructions.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@amc-nu amc-nu changed the title edge_auto_launcher. update launch files to match new autoware univers… fix:(launch) update launch files to match new autoware universe package naming Sep 5, 2024
@amc-nu amc-nu changed the title fix:(launch) update launch files to match new autoware universe package naming fix(launch): update launch files to match new autoware universe package naming Sep 5, 2024
Copy link
Collaborator

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amc-nu
I appreciate your support in updating edge-auto so that it aligns with recent autoware! I approve this PR as a first step for the updating.

@manato manato merged commit 5b4593d into tier4:main Sep 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants