fix:(launch) update launch files to match new autoware universe package naming #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amc-nu
changed the title
manato
requested changes
Sep 4, 2024
There was a problem hiding this comment.
@a-yyg @amc-nu
First of all, I really appreciate your updating this repository.
I would propose to avoid this kind of ONNXs on this repository because of their size. Besides, the modification of edge-auto side PR contains a role to download similar ONNX files, I'd appreciate it if you guys remove ONNX files from this PR.
| @@ -2,24 +2,26 @@ | |||
| <arg name="input/pointcloud" default="input/pointcloud"/> | |||
| <arg name="output/objects" default="output/objects"/> | |||
| <arg name="model_name" default="centerpoint_tiny" description="options: `centerpoint` or `centerpoint_tiny`"/> | |||
| <arg name="model_path" default="$(find-pkg-share lidar_centerpoint)/data"/> | |||
| <arg name="model_path" default="$(find-pkg-share edge_auto_launch)/config/centerpoint_models"/> | |||
There was a problem hiding this comment.
Suggested change
| <arg name="model_path" default="$(find-pkg-share edge_auto_launch)/config/centerpoint_models"/> | |
| <arg name="model_path" default="$(env HOME)/autoware_data/lidar_centerpoint"/> |
Would you mind to change the default root directory of ONNXs because they will be downloaded by the setup ansible?
There was a problem hiding this comment.
…e universe changes Signed-off-by: amc-nu <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
This PR updates the
edge_auto_launchlaunch files to match the new autoware naming scheme introduced in version 2024.07.Review Procedure
Launch the system as usual following the README instructions.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks