Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_lane_change_module): avoid empty current lanes #1445

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

KYabuuchi
Copy link

@KYabuuchi KYabuuchi commented Aug 6, 2024

Description

Overview:

I have modified the lane change module so that it can utilize current_lanes even if target_lanes is empty.

Details:

When driving manually with Autoware activated, sometimes target_lanes would be empty, which would cause current_lanes to be empty as well.
If current_lanes is empty, an error occurs in the current_lanes.back() that is called afterwards.

Specifically, I encountered the error at utils::lane_change::calcMinimumLaneChangeLength(
route_handler, current_lanes.back(), *lane_change_parameters_, direction_);

Related links

Parent Issue:

  • Nothing

Private Links:

How was this PR tested?

I tested by logging simulator with the TIER IV private rosbag and verified that the planner is now stable and no longer aborts.

Notes for reviewers

Recently, this phenomenon has become more frequent, but the reason why target_lanes becomes empty during manual driving remains unclear.

Interface changes

Does not change.

Effects on system behavior

Does not change.

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit c43d7d4 into beta/v0.29.0 Aug 7, 2024
28 checks passed
@shmpwk shmpwk deleted the fix/avoid_empty_current_lanes branch August 7, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants