Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RepeatableFlakyTest #24

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Remove RepeatableFlakyTest #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions player/src/androidTest/kotlin/com/tidal/sdk/player/playlog/PlayLogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ import com.tidal.sdk.player.events.playlogtest.PlayLogTestDefaultEventReporterCo
import com.tidal.sdk.player.events.reflectionComponentFactoryF
import com.tidal.sdk.player.playbackengine.model.Event
import com.tidal.sdk.player.playbackengine.model.Event.MediaProductEnded
import com.tidal.sdk.player.repeatableflakytest.RepeatableFlakyTest
import com.tidal.sdk.player.repeatableflakytest.RepeatableFlakyTestRule
import com.tidal.sdk.player.setBodyFromFile
import kotlin.time.Duration.Companion.milliseconds
import kotlin.time.Duration.Companion.seconds
Expand Down Expand Up @@ -68,9 +66,6 @@ class PlayLogTest {
@get:Rule
val server = MockWebServer()

@get:Rule
val repeatableFlakyTestRule = RepeatableFlakyTestRule()

private val eventReporterCoroutineScope =
TestScope(StandardTestDispatcher(TestCoroutineScheduler()))
private val responseDispatcher = PlayLogTestMockWebServerDispatcher(server)
Expand Down Expand Up @@ -147,22 +142,18 @@ class PlayLogTest {
verifyNoMoreInteractions(eventSender)
}

@RepeatableFlakyTest // Playback may take longer in practice than it should in theory
@Test
fun loadAndPlayUntilEndNoNulls() =
loadAndPlayUntilEnd(MediaProduct(ProductType.TRACK, "1", "TESTA", "456"))

@RepeatableFlakyTest // Playback may take longer in practice than it should in theory
@Test
fun loadAndPlayUntilEndNullSourceType() =
loadAndPlayUntilEnd(MediaProduct(ProductType.TRACK, "1", null, "789"))

@RepeatableFlakyTest // Playback may take longer in practice than it should in theory
@Test
fun loadAndPlayUntilEndNullSourceId() =
loadAndPlayUntilEnd(MediaProduct(ProductType.TRACK, "1", "TESTB", null))

@RepeatableFlakyTest // Playback may take longer in practice than it should in theory
@Test
fun loadAndPlayUntilEndNullSourceTypeNullSourceId() =
loadAndPlayUntilEnd(MediaProduct(ProductType.TRACK, "1", null, null))
Expand Down
12 changes: 0 additions & 12 deletions .../testutil/src/main/kotlin/com/tidal/sdk/player/repeatableflakytest/RepeatableFlakyTest.kt
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions ...tutil/src/main/kotlin/com/tidal/sdk/player/repeatableflakytest/RepeatableFlakyTestRule.kt
View file
Open in desktop

This file was deleted.

Loading