Remove RepeatableFlakyTest #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are no longer flaky when it comes to asserting before reporting has finished, so the repeat mechanism is no longer required in that sense. If the timeout for playback proves to be a problem, then that should be bumped instead, as it is virtually higher for other tests (they use the same timeout for playback completion, even though said playback is not full).
stoyicker
force-pushed
the
jantonio/remove_repeatable_flaky_test
branch
from
2d08360
to
9ca5200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are no longer flaky when it comes to asserting before reporting has finished, so the repeat mechanism is no longer required in that sense.
If the timeout for playback proves to be a problem, then that should be bumped instead, as it is virtually higher for other tests (they use the same timeout for playback completion, even though said playback is not full).