-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyphenated file support #424
Changes from 11 commits
1c47496
6c0ab1d
61f08cd
232c51a
68ba6db
bc12fe2
ef2c62f
e508f24
7add654
ac2027f
53bdd81
c8cbaa1
9f30c30
a6e531d
2187e99
cf2b8e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,4 +18,4 @@ nozap: thrift/nozap.thrift $(THRIFTRW) | |
$(THRIFTRW) --no-recurse --no-zap $< | ||
|
||
%: thrift/%.thrift $(THRIFTRW) | ||
$(THRIFTRW) --no-recurse $< | ||
$(THRIFTRW) $< | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did we drop this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have nested directory and it should recursively try to generate code. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we pass in the normalized path on line 272, can we remove this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RelativePackage is responsible for generating the import package name, as below, hence needed, while the line 272 is there for generating the base package name of file for code gen.