Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyphenated file support #424

Merged
merged 16 commits into from
Oct 16, 2019
Merged

Hyphenated file support #424

merged 16 commits into from
Oct 16, 2019

Commits on Oct 9, 2019

  1. Hyphenated file support

    @abhishekparwal
    abhishekparwal committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    1c47496 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. gen code

    @abhishekparwal
    abhishekparwal committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    6c0ab1d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. review comments

    @abhishekparwal
    abhishekparwal committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    61f08cd View commit details
    Browse the repository at this point in the history

  2. generated go code

    @abhishekparwal
    abhishekparwal committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    232c51a View commit details
    Browse the repository at this point in the history

  3. test msg assert

    @abhishekparwal
    abhishekparwal committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    68ba6db View commit details
    Browse the repository at this point in the history

  4. stylistic code comments

    @abhishekparwal
    abhishekparwal committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    bc12fe2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. code review comments

    @abhishekparwal
    abhishekparwal committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    ef2c62f View commit details
    Browse the repository at this point in the history

  2. addressing paths to be retained and just package to be renamed, i.e.… 

    … path/to/file.thrift becomes path/to/file/*.go. Previously, file.thrift became package $file. Now it would be package $(normalize $file)
    @abhishekparwal
    abhishekparwal committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    e508f24 View commit details
    Browse the repository at this point in the history

  3. fix test

    @abhishekparwal
    abhishekparwal committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    7add654 View commit details
    Browse the repository at this point in the history

  4. undoing accidental comment

    @abhishekparwal
    abhishekparwal committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    ac2027f View commit details
    Browse the repository at this point in the history

  5. quick test - loading the generated types

    @abhishekparwal
    abhishekparwal committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    53bdd81 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. review comments

    @abhishekparwal
    abhishekparwal committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c8cbaa1 View commit details
    Browse the repository at this point in the history

  2. Update gen/generate_test.go 

    Co-Authored-By: Abhinav Gupta <[email protected]>
    @abhishekparwal @abhinav
    abhishekparwal and abhinav committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    9f30c30 View commit details
    Browse the repository at this point in the history

  3. Update gen/internal/tests/thrift/hyphenated_file.thrift 

    Co-Authored-By: Abhinav Gupta <[email protected]>
    @abhishekparwal @abhinav
    abhishekparwal and abhinav committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    a6e531d View commit details
    Browse the repository at this point in the history

  4. Update gen/generate_test.go 

    Co-Authored-By: Abhinav Gupta <[email protected]>
    @abhishekparwal @abhinav
    abhishekparwal and abhinav committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    2187e99 View commit details
    Browse the repository at this point in the history

  5. generated file

    @abhishekparwal
    abhishekparwal committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    cf2b8e2 View commit details
    Browse the repository at this point in the history