Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of worker logs #287

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Reduce verbosity of worker logs #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
393025b
Reduce verbosity of worker logs
isobelormiston Mar 5, 2024
d81b721
Remove more log lines, and make sure errors contain hash
isobelormiston Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions mettle/worker/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ func (w *worker) runTask(msg *pubsub.Message) *pb.ExecuteResponse {
}
}
w.actionDigest = req.ActionDigest
log.Notice("Received task for action digest %s", w.actionDigest.Hash)
log.Debug("Received task for action digest %s", w.actionDigest.Hash)
w.lastURL = w.actionURL()

action, command, status := w.fetchRequestBlobs(req)
Expand Down Expand Up @@ -628,9 +628,9 @@ func (w *worker) prepareDirWithPacks(action *pb.Action, command *pb.Command, use
fetchDurations.Observe(time.Since(start).Seconds())
if total := w.cachedBytes + w.downloadedBytes; total > 0 {
percentage := float64(w.downloadedBytes) * 100.0 / float64(total)
log.Notice("Prepared directory for %s; downloaded %s / %s (%0.1f%%).", w.actionDigest.Hash, humanize.Bytes(uint64(w.downloadedBytes)), humanize.Bytes(uint64(total)), percentage)
log.Debug("Prepared directory for %s; downloaded %s / %s (%0.1f%%).", w.actionDigest.Hash, humanize.Bytes(uint64(w.downloadedBytes)), humanize.Bytes(uint64(total)), percentage)
} else {
log.Notice("Prepared directory for %s", w.actionDigest.Hash)
log.Debug("Prepared directory for %s", w.actionDigest.Hash)
}
log.Debug("Metadata fetch: %s, dir creation: %s, file download: %s", w.metadataFetch, w.dirCreation, w.fileDownload)
return nil
Expand Down Expand Up @@ -691,7 +691,7 @@ func (w *worker) execute(req *pb.ExecuteRequest, action *pb.Action, command *pb.
cmd.Env[i] = v.Name + "=" + v.Value
}
err := w.runCommand(cmd, duration)
log.Notice("Completed execution for %s", w.actionDigest.Hash)
log.Debug("Completed execution for %s", w.actionDigest.Hash)
execEnd := time.Now()
w.metadata.VirtualExecutionDuration = durationpb.New(duration)
w.metadata.ExecutionCompletedTimestamp = toTimestamp(execEnd)
Expand Down Expand Up @@ -728,7 +728,7 @@ func (w *worker) execute(req *pb.ExecuteRequest, action *pb.Action, command *pb.
w.observeSysUsage(cmd, execDuration)
if err != nil {
log.Debug("Execution failed.\nStdout: %s\nStderr: %s", w.stdout.String(), w.stderr.String())
msg := "Execution failed: " + err.Error()
msg := "Execution failed for " + w.actionDigest.Hash + ": " + err.Error()
msg += w.writeUncachedResult(ar, msg)
// Attempt to collect outputs. They may exist and contain useful information such as a test.results file
_ = w.collectOutputs(ar, command)
Expand Down Expand Up @@ -756,7 +756,7 @@ func (w *worker) execute(req *pb.ExecuteRequest, action *pb.Action, command *pb.
end := time.Now()
w.metadata.OutputUploadCompletedTimestamp = toTimestamp(end)
uploadDurations.Observe(end.Sub(execEnd).Seconds())
log.Notice("Uploaded outputs for %s", w.actionDigest.Hash)
log.Debug("Uploaded outputs for %s", w.actionDigest.Hash)
w.metadata.WorkerCompletedTimestamp = toTimestamp(time.Now())
w.observeCosts()

Expand All @@ -781,13 +781,13 @@ func (w *worker) execute(req *pb.ExecuteRequest, action *pb.Action, command *pb.
},
})
if err != nil {
log.Error("Failed to upload action result: %s", err)
log.Error("Failed to upload action result for %s: %s", w.actionDigest.Hash, err)
return &pb.ExecuteResponse{
Status: status(err, codes.Internal, "Failed to upload action result: %s", err),
Result: ar,
}
}
log.Notice("Uploaded action result for %s", w.actionDigest.Hash)
log.Debug("Uploaded action result for %s", w.actionDigest.Hash)
return &pb.ExecuteResponse{
Status: &rpcstatus.Status{Code: int32(codes.OK)},
Result: ar,
Expand Down
Loading