Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of worker logs #287

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Reduce verbosity of worker logs #287

merged 2 commits into from
Mar 5, 2024

Conversation

isobelormiston
Copy link
Contributor

@isobelormiston isobelormiston commented Mar 5, 2024

The existing logging for a successful action looks like this:
“Received task..”
“Executing action..”
“Prepared directory for..”
“Completed execution for..”
“Uploaded outputs for..”
“Uploaded action result for..”

This reduces it to just “Executing action..”

@isobelormiston isobelormiston requested a review from Hamishpk March 5, 2024 10:46
@Hamishpk
Copy link
Contributor

Hamishpk commented Mar 5, 2024

Should we change the other happy path notice logs to debug and ensure all error logs are up to date?

For example we don't need to know a worker uploaded all outputs but we do need to know if it failed to upload outputs.

@isobelormiston
Copy link
Contributor Author

This now logs only "Executing action ....", and the errors include the action hash so we can follow an action's journey.

@isobelormiston isobelormiston merged commit cf810d0 into master Mar 5, 2024
7 checks passed
@isobelormiston isobelormiston deleted the worker-logs branch March 5, 2024 17:36
Hamishpk pushed a commit to Hamishpk/please-servers that referenced this pull request Mar 7, 2024
* Reduce verbosity of worker logs

* Remove more log lines, and make sure errors contain hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants