Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove tw-components <Badge /> #5370

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring badge components across various files, simplifying their usage and styling. It removes unnecessary props and imports, standardizing the way Badge components are utilized throughout the application.

Detailed summary

  • Deleted Badge component from apps/dashboard/src/tw-components/badge.tsx.
  • Simplified OpenSeaPropertyBadge by removing props and using a default Badge.
  • Updated BillingHeader, PlanCard, and BillingPlanCard to use simpler Badge implementations.
  • Removed Badge imports where not needed in multiple files.
  • Adjusted AccountSigner and ContractSourcesPage to streamline Badge usage with fewer props.
  • Changed button variant in ContractSourcesPage from solid to primary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: b30177c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:19am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 2:19am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 2:19am
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 2:19am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 05:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 05:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 05:02 Inactive
@kien-ngo kien-ngo marked this pull request as ready for review November 9, 2024 05:02
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (040e478) to head (b30177c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5370   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1068     1068           
  Lines       55433    55433           
  Branches     4000     4000           
=======================================
  Hits        25112    25112           
  Misses      29634    29634           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 040e478
packages 40.32% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.15 KB (0%) 883 ms (0%) 550 ms (+5.9% 🔺) 1.5 s
thirdweb (cjs) 104.69 KB (0%) 2.1 s (0%) 736 ms (-11.88% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 92 ms (+222.36% 🔺) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+169.11% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 194 ms (+144.97% 🔺) 570 ms

@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 9, 2024 — with Graphite App
@kien-ngo kien-ngo force-pushed the kien/tw-component-contract-action-buttons branch from 77ba281 to 304c4f9 Compare November 10, 2024 09:42
@kien-ngo kien-ngo force-pushed the kien/remove-tw-component-Badge branch from 929a141 to 396f55d Compare November 10, 2024 09:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 10, 2024 09:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 10, 2024 09:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 10, 2024 09:42 Inactive
@kien-ngo kien-ngo changed the base branch from kien/tw-component-contract-action-buttons to graphite-base/5370 November 11, 2024 00:10
@kien-ngo kien-ngo force-pushed the kien/remove-tw-component-Badge branch from 396f55d to 904ee3a Compare November 11, 2024 00:16
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 00:16 Inactive
Copy link

graphite-app bot commented Nov 13, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the usage of the `Badge` component across various files, simplifying its props and styling. It also removes the `Badge` component from some files and updates imports accordingly.

### Detailed summary
- Deleted `badge.tsx` file.
- Removed `Badge` imports and usage in several components, replacing them with simpler implementations.
- Updated `Badge` usage to use class names for styling instead of props in multiple components.
- Adjusted the `Badge` component's props to reduce complexity and improve readability.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/remove-tw-component-Badge branch from fcbb910 to b30177c Compare November 13, 2024 02:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 02:15 Inactive
@graphite-app graphite-app bot merged commit b30177c into main Nov 13, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/remove-tw-component-Badge branch November 13, 2024 02:19
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 02:19 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 02:19 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 02:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants