-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove tw-components <Badge /> #5370
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5370 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1068 1068
Lines 55433 55433
Branches 4000 4000
=======================================
Hits 25112 25112
Misses 29634 29634
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
77ba281
to
304c4f9
Compare
929a141
to
396f55d
Compare
304c4f9
to
a1b518c
Compare
396f55d
to
904ee3a
Compare
8e930fa
to
dae4ea6
Compare
dae4ea6
to
468f071
Compare
468f071
to
fcbb910
Compare
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the usage of the `Badge` component across various files, simplifying its props and styling. It also removes the `Badge` component from some files and updates imports accordingly. ### Detailed summary - Deleted `badge.tsx` file. - Removed `Badge` imports and usage in several components, replacing them with simpler implementations. - Updated `Badge` usage to use class names for styling instead of props in multiple components. - Adjusted the `Badge` component's props to reduce complexity and improve readability. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
fcbb910
to
b30177c
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring badge components across various files, simplifying their usage and styling. It removes unnecessary props and imports, standardizing the way
Badge
components are utilized throughout the application.Detailed summary
Badge
component fromapps/dashboard/src/tw-components/badge.tsx
.OpenSeaPropertyBadge
by removing props and using a defaultBadge
.BillingHeader
,PlanCard
, andBillingPlanCard
to use simplerBadge
implementations.Badge
imports where not needed in multiple files.AccountSigner
andContractSourcesPage
to streamlineBadge
usage with fewer props.ContractSourcesPage
fromsolid
toprimary
.