-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove tw-components from marketplace components #5367
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5367 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 1070 1070
Lines 55671 55671
Branches 4081 4081
=======================================
Hits 25446 25446
Misses 29536 29536
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
75c4d12
to
c274358
Compare
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on replacing the `tw-components` library's `Text` and `Heading` components with standard HTML elements like `<p>` and `<div>` to simplify the code structure and improve styling consistency across various components in the dashboard. ### Detailed summary - Replaced `Text` components with `<p>` in `csv-data-table.tsx`, `ContractDirectListingsPage.tsx`, and `ContractEnglishAuctionsPage.tsx`. - Changed `Heading` components to `<p>` in multiple files for consistency. - Updated button variants from `solid` to `default` in `marketplace-table.tsx`. - Removed unnecessary imports of `Text` and `Heading` from `tw-components` in several files. - Adjusted styling classes for better alignment and consistency. - Enhanced layout structure in the `ListingDrawer` and `CreateListingsForm` components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
c274358
to
453e45b
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the UI components across several files in the dashboard application, replacing instances of the
Heading
andText
components fromtw-components
with standard HTML elements likep
for better styling consistency.Detailed summary
Text
andHeading
components with<p>
elements incsv-data-table.tsx
,ContractDirectListingsPage.tsx
, andContractEnglishAuctionsPage.tsx
.MarketplaceTable
component to use<p>
instead ofText
.ListingDrawer
to replaceHeading
andText
with<p>
elements for various labels.solid
todefault
inMarketplaceTable
.tw-components
and added imports from other UI components.