Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove tw-components from marketplace components #5367

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the UI components across several files in the dashboard application, replacing instances of the Heading and Text components from tw-components with standard HTML elements like p for better styling consistency.

Detailed summary

  • Replaced Text and Heading components with <p> elements in csv-data-table.tsx, ContractDirectListingsPage.tsx, and ContractEnglishAuctionsPage.tsx.
  • Updated MarketplaceTable component to use <p> instead of Text.
  • Modified ListingDrawer to replace Heading and Text with <p> elements for various labels.
  • Changed button variants from solid to default in MarketplaceTable.
  • Removed unnecessary imports from tw-components and added imports from other UI components.
  • Adjusted layout classes for consistency across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: 453e45b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 0:12am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 11, 2024 0:12am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 11, 2024 0:12am
wallet-ui ⬜️ Skipped (Inspect) Nov 11, 2024 0:12am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 04:24 Inactive
Copy link

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 9, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 9, 2024 04:24
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (07af647) to head (453e45b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5367   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 07af647
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 3 s (+16.16% 🔺) 3.9 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 5.2 s (-33.02% 🔽) 7.3 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 280 ms (-30.77% 🔽) 377 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 70 ms (+40.15% 🔺) 80 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 673 ms (+114.36% 🔺) 1.1 s

Copy link

graphite-app bot commented Nov 11, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on replacing the `tw-components` library's `Text` and `Heading` components with standard HTML elements like `<p>` and `<div>` to simplify the code structure and improve styling consistency across various components in the dashboard.

### Detailed summary
- Replaced `Text` components with `<p>` in `csv-data-table.tsx`, `ContractDirectListingsPage.tsx`, and `ContractEnglishAuctionsPage.tsx`.
- Changed `Heading` components to `<p>` in multiple files for consistency.
- Updated button variants from `solid` to `default` in `marketplace-table.tsx`.
- Removed unnecessary imports of `Text` and `Heading` from `tw-components` in several files.
- Adjusted styling classes for better alignment and consistency.
- Enhanced layout structure in the `ListingDrawer` and `CreateListingsForm` components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/tw-component-marketplace branch from c274358 to 453e45b Compare November 11, 2024 00:09
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 00:09 Inactive
@graphite-app graphite-app bot merged commit 453e45b into main Nov 11, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/tw-component-marketplace branch November 11, 2024 00:13
@vercel vercel bot temporarily deployed to Production – docs-v2 November 11, 2024 00:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 11, 2024 00:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 11, 2024 00:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants