Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bank api calls to use the js sdk #610

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Conversation

@zinoadidi
Copy link

@tomijaga you read my mind.

Just keep going when Justin gets back he will look at all of them

@tomijaga
Copy link
Author

tomijaga commented Apr 4, 2021

@zinoadidi I feel like I will end up creating more work for myself if Justin comes back and doesn't approve of a change I made in the earlier Pr's.

@zinoadidi
Copy link

ok, maybe we can get one of the other contributors who know about this account manager to take a look first, then when Justin shows up, he just rechecks it, that way there is less room for errors.

We could also get bucky to help us merge them since we will still have to review when we merge to the main branch anyways.
That way if something is wrong you only need to create a new PR as opposed to changing existing ones

@stweyel
Copy link
Contributor

stweyel commented Apr 4, 2021

ok, maybe we can get one of the other contributors who know about this account manager to take a look

@tomijaga @zinoadidi ...if you check mine... i'll check yours ;-)
No seriously. I'll install your branch and test it. Maybe it can help to reduce approval/testing times.
If anyone may have a look at my PR #608 feel free to comment

@tomijaga
Copy link
Author

tomijaga commented Apr 4, 2021

@stweyel we still won't be able to merge it.
The issue was made from a windows device.
I use a mac so i won't be able to help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants