Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Rest of Bank functionality in account manager uses JS SDK #142

Closed
zinoadidi opened this issue Apr 12, 2021 · 3 comments
Closed

[Task] Rest of Bank functionality in account manager uses JS SDK #142

zinoadidi opened this issue Apr 12, 2021 · 3 comments
Assignees
Labels
third-party tasks outside tnb-js sdk

Comments

@zinoadidi
Copy link
Contributor

Task

Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!

Overview

fetchBankBankTransactions src/renderer/dispatchers/banks.ts Gets all the bank transactions for the specified bank
fetchBankBlocks src/renderer/dispatchers/banks.ts Gets all the blocks for the specified bank
fetchBankConfirmationBlocks src/renderer/dispatchers/banks.ts Gets all the banks confirmation blocks
fetchBankInvalidBlocks src/renderer/dispatchers/banks.ts Gets all the Invalid blocks for a specified bank
fetchBankValidatorConfirmationServices src/renderer/dispatchers/banks.ts Gets all the confirmations blocks for a specified banks blocks

Behavior

Account manager uses js sdk installed from NPM https://www.npmjs.com/package/thenewboston
Rest of Bank functionality in Account manager uses JS SDK

/* code examples are awesome */

Please ask for this task to be assigned to you and earn and its sweet reward 😉

Remember to include your account number in your PR description for us to pay you 💰

** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing

@tomijaga
Copy link
Contributor

@zinoadidi I've added all of these methods

@zinoadidi
Copy link
Contributor Author

@tomijaga for the sake of bureaucracy :)
Lets tag the respective PR so i can get Justin to review / close the tasks from this side

@zinoadidi
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third-party tasks outside tnb-js sdk
Projects
None yet
Development

No branches or pull requests

2 participants