Skip Regression Tests For Versions Lower Than Python 3.9 and Remove Elastic Cost #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MUCDK And now it fails because ElasticL1 was removed from ottjax 2 hours ago. |
|
remove the tests for Elastic costs, and open an issue to investigate later. I saw that Mike restructured quite a. bit. Elastic costs are not super crucial , so fine to have them not for the moment. Thanks! |
for more information, see https://pre-commit.ci
selmanozleyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tests for the CI.
skipping regression tests depending on the version and removing elastic costs.