Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastic Costs again or asses if they are necessary or not #726

Closed
selmanozleyen opened this issue Jul 3, 2024 · 3 comments
Closed

Comments

@selmanozleyen
Copy link
Collaborator

In this PR #725 I removed the Elastic cost functions since ottjax removed them with this commit: ott-jax/ott@d5d8a47

We should decide what we are going to do about this

@selmanozleyen selmanozleyen changed the title Add Elastic Costs again or asses if it's necessary or not Add Elastic Costs again or asses if they are necessary or not Jul 3, 2024
@marcocuturi
Copy link

@michalk8 I think this should be easy?

@michalk8
Copy link
Collaborator

michalk8 commented Jul 9, 2024

Yes, they've been refactored to just use RegTICost + a regularization class; should be fairly easy to incorporate the changes.

@selmanozleyen
Copy link
Collaborator Author

selmanozleyen commented Sep 23, 2024

if then necessary we'll add it, so I am closing this issue for now. Just wanted to know how important it was to replace them and their removal is documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants