Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheiaCoV] Reorder flu assembly segments in largest-to-smallest order #630

Closed
emily-smith1 opened this issue Sep 20, 2024 · 3 comments · Fixed by #635
Closed

[TheiaCoV] Reorder flu assembly segments in largest-to-smallest order #630

emily-smith1 opened this issue Sep 20, 2024 · 3 comments · Fixed by #635
Assignees

Comments

@emily-smith1
Copy link

🆒

📌 Explain the Request

Re-ordering of the flu segments in the assembly_fasta file output by TheiaCoV in largest to smallest order: PB1, PB2, PA, HA, NP, NA, MP, NS, in accordance with Nextstrain/UShER formatting.

@Michal-Babins Michal-Babins self-assigned this Sep 25, 2024
@Michal-Babins
Copy link
Contributor

Michal-Babins commented Sep 25, 2024

Is the expectation here to sort the segments and overwrite the file in place of the assembly fasta OR to save the ordered output to a modified file (ordered_assembly.fasta)?

@emily-smith1
Copy link
Author

I'd suggest overwriting the existing assembly_fasta file to cut down on the number of output columns, unless the existing order is necessary for something downstream.

@Michal-Babins
Copy link
Contributor

Did some testing against my branch and was able to confirm the assembly fasta correctly represents the ordered segments (PB2,PB1,PA,HA,NP,NA,MP,NS) after running end to end.

Job history relating to this run can be found here, showing 10 successful runs.

You can check all the assemblies in the flu_testing data table to confirm the assemblies look as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants