Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheiaCoV] task_ncbi_scrub.wdl CPU and singleton bugs #127

Closed
andrewjpage opened this issue Jul 24, 2023 · 2 comments · Fixed by #527
Closed

[TheiaCoV] task_ncbi_scrub.wdl CPU and singleton bugs #127

andrewjpage opened this issue Jul 24, 2023 · 2 comments · Fixed by #527
Assignees
Labels
in progress This issue is being actively worked on

Comments

@andrewjpage
Copy link
Contributor

andrewjpage commented Jul 24, 2023

This software assumes all CPUs are available on the system for it to use, so it can explode. Explicitly pass in the CPUs to the command.

Additionally there is an edge case for PE reads where you could have one read removed from one direction and not the other, sending everything out of order. Change the code to ensure that the reads are still paired after scrubbing and remove all singletons. Where one read is masked with Ns, instead of being removed, this is still effectively a singleton and both reads should be removed.

@kapsakcj
Copy link
Contributor

kapsakcj commented Aug 2, 2023

Would be a good time to upgrade to the latest v2.2.0 of the scrubber: https://github.com/ncbi/sra-human-scrubber/releases/tag/2.2.0

Will also need to push the docker image to our GAR. Here's where v2.2.0 docker image can be found: https://hub.docker.com/r/ncbi/sra-human-scrubber/tags

@kapsakcj
Copy link
Contributor

kapsakcj commented Aug 4, 2023

new version of the scrubber was just released to fix a bug with interleaved paired end files: https://github.com/ncbi/sra-human-scrubber/releases/tag/2.2.1

@sage-wright sage-wright added the in progress This issue is being actively worked on label Dec 19, 2023
@sage-wright sage-wright linked a pull request Dec 20, 2023 that will close this issue
4 tasks
@cimendes cimendes self-assigned this Jan 3, 2024
@sage-wright sage-wright changed the title task_ncbi_scrub.wdl CPU and singleton bugs [TheiaCoV] task_ncbi_scrub.wdl CPU and singleton bugs Apr 24, 2024
@cimendes cimendes removed a link to a pull request Jul 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress This issue is being actively worked on
Projects
None yet
4 participants