Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ergast - results final position filter #494

Merged
merged 12 commits into from
Dec 28, 2023
Merged

Ergast - results final position filter #494

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f554c8e
Update interface.py
Lombardoc4 Dec 7, 2023
bb389a6
if endpoint selector includes more than season and/or year dont appen…
Lombardoc4 Dec 8, 2023
b8ca79e
mimicking laps endpoint behavior to omit endpoint value from url in s…
Lombardoc4 Dec 18, 2023
7e84365
additional check for endpoint value to further scope removal in base url
Lombardoc4 Dec 18, 2023
b6bb5cb
appending base_url special cases with proper format
Lombardoc4 Dec 19, 2023
aa72579
specify endpoint is the final selector for the ergast url
Lombardoc4 Dec 20, 2023
df14659
omit race_schedule conditional
Lombardoc4 Dec 20, 2023
24e6630
add standings_position for results
Lombardoc4 Dec 20, 2023
893f396
minor fixes, add more tests
theOehrly Dec 26, 2023
d092038
Merge branch 'master' into results-position-filter
Lombardoc4 Dec 27, 2023
c1cff68
Merge branch 'master' into fork/results-position-filter
theOehrly Dec 28, 2023
143f22d
use results_position, fix conflicts
theOehrly Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions fastf1/ergast/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,6 @@ def _build_url(
selectors.append(f"/{round}")
if grid_position is not None:
selectors.append(f"/grid/{grid_position}")
if results_position is not None:
selectors.append(f"/results/{results_position}")
if fastest_rank is not None:
selectors.append(f"/fastest/{fastest_rank}")

Expand Down Expand Up @@ -482,6 +480,12 @@ def _build_url(
elif endpoint == 'constructorStandings':
endpoint = f"constructorStandings/{standings_position}"

if results_position is not None:
if endpoint in ('results', 'qualifying', 'sprint'):
endpoint = f"{endpoint}/{results_position}"
else:
selectors.append(f"/results/{results_position}")

if lap_number is not None:
if endpoint == 'laps':
endpoint = f"laps/{lap_number}"
Expand Down Expand Up @@ -1019,6 +1023,7 @@ def get_race_results(
constructor: Optional[str] = None,
driver: Optional[str] = None,
grid_position: Optional[int] = None,
results_position: Optional[int] = None,
fastest_rank: Optional[int] = None,
status: Optional[str] = None,
result_type: Optional[Literal['pandas', 'raw']] = None,
Expand All @@ -1042,6 +1047,8 @@ def get_race_results(
(default: all)
driver: select a driver by its driver id (default: all)
grid_position: select a grid position by its number (default: all)
results_position: select a finishing result by its position
(default: all)
fastest_rank: select fastest by rank number (default: all)
status: select by finishing status (default: all)
result_type: Overwrites the default result type
Expand All @@ -1062,6 +1069,7 @@ def get_race_results(
'constructor': constructor,
'driver': driver,
'grid_position': grid_position,
'results_position': results_position,
'fastest_rank': fastest_rank,
'status': status}

Expand Down Expand Up @@ -1151,6 +1159,7 @@ def get_sprint_results(
constructor: Optional[str] = None,
driver: Optional[str] = None,
grid_position: Optional[int] = None,
results_position: Optional[int] = None,
status: Optional[str] = None,
result_type: Optional[Literal['pandas', 'raw']] = None,
auto_cast: Optional[bool] = None,
Expand All @@ -1173,6 +1182,8 @@ def get_sprint_results(
(default: all)
driver: select a driver by its driver id (default: all)
grid_position: select a grid position by its number (default: all)
results_position: select a finishing result by its position
(default: all)
status: select by finishing status (default: all)
result_type: Overwrites the default result type
auto_cast: Overwrites the default value for ``auto_cast``
Expand All @@ -1192,6 +1203,7 @@ def get_sprint_results(
'constructor': constructor,
'driver': driver,
'grid_position': grid_position,
'results_position': results_position,
'status': status}

return self._build_default_result(endpoint='sprint',
Expand Down