-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergast - results final position filter #494
Ergast - results final position filter #494
Conversation
Testing fork
…d final endpoint val
…tatus, driver, constructors, and circuit
Something went wrong here I think? +1460 lines does not seem right. I think you accidentally duplicated a bunch of code? |
My fault, I wanted to start fresher, without the changes from my other PR. Got a bit sloppy with the initial branch setup, should be all clean now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment about the stadnings position being appended at the end of the API path needs to be addressed.
Also, this PR should be rebased onto master again.
Expanding
standings_position
from Driver & Constructor Standings to Race, Qualifying, & Sprint results.Changes for
get_race_results()
,get_qualifying_results()
,get_sprint_results()
standings_position
the same as it is done forget_driver_standings()
andget_constructor_standings()
. This name does not accurately describe the value. However the var is pre-existing and exhibits the same behavior as needed.Changes for building the url:
standings_position
as the final selector when building the url.Ergast documentation to support
Note this is a fresh version of interface.py omitting changes from other PRs