Skip to content

Commit

Permalink
Fix Linking Issue for Non-VISA Executables (#32)
Browse files Browse the repository at this point in the history
The cargo resolver will automatically unify features when running `cargo
build --workspace`, so we need to make sure that we build VISA-enabled
and
VISA-disabled packages separately.
  • Loading branch information
esarver authored Sep 17, 2024
1 parent 85bd7ee commit e2e837a
Show file tree
Hide file tree
Showing 6 changed files with 106 additions and 242 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ jobs:
run: |
git config --global credential.helper store
echo "https://${{vars.SERVICE_ACCOUNT_USER}}:${{secrets.SERVICE_ACCOUNT_PAT}}@github.com" > ~/.git-credentials
cargo build --target "${{matrix.triple}}" --release
cargo build --target "${{matrix.triple}}" --release --package kic --package kic-discover
cargo build --target "${{matrix.triple}}" --release --package kic-visa --package kic-discover-visa
- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
Expand Down
Loading

0 comments on commit e2e837a

Please sign in to comment.