Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset min occurs only for multi element choices #828

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jul 16, 2023

📒 Description

Reset min occurs only for multi element choices

Resolves #822

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (68d5071) 99.96% compared to head (af19889) 99.96%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #828    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files         104      104            
  Lines        9263     9262     -1     
  Branches     2073     1611   -462     
========================================
- Hits         9260     9259     -1     
  Partials        3        3            
Impacted Files Coverage Δ
xsdata/codegen/handlers/create_compound_fields.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tefra tefra merged commit 9a894ae into main Jul 16, 2023
17 of 18 checks passed
@tefra tefra deleted the reset-min-occurs-for-choices-with-more-than-one-element branch July 16, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When an element does not specify type, it loses minOccurs
1 participant