When an element does not specify type, it loses minOccurs

[skinkie]

The method should_reset_required resets minOccurs to zero for situations where a type on an element is not defined. What is the rationale for this behavior?

<?xml version="1.0"?>
<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema" targetNamespace="http://xsdtesting" xmlns:x="http://xsdtesting" xmlns:imp="http://importedXSD">
        <xsd:element name="foo" final="#all"/>
        <xsd:complexType name="B">
                <xsd:sequence>
                        <xsd:choice minOccurs="1" maxOccurs="1">
                                <xsd:element ref="x:foo"/>
                                <xsd:element name="c2" minOccurs="1" maxOccurs="1"/>
                        </xsd:choice>
                        <xsd:choice minOccurs="1" maxOccurs="1">
                                <xsd:element name="d1" minOccurs="1" maxOccurs="1" block="#all"/>
                                <xsd:element name="d2" minOccurs="1" maxOccurs="1" block="#all"/>
                        </xsd:choice>
                </xsd:sequence>
        </xsd:complexType>
        <xsd:complexType name="R">
                <xsd:complexContent>
                        <xsd:restriction base="x:B">
                                <xsd:sequence>
                                        <xsd:element ref="x:foo"/>
                                        <xsd:element name="d1" minOccurs="1" maxOccurs="1" block="#all"/>
                                </xsd:sequence>
                        </xsd:restriction>
                </xsd:complexContent>
        </xsd:complexType>
        <xsd:element name="doc">
                <xsd:complexType>
                        <xsd:choice>
                                <xsd:element name="elem" type="x:R"/>
                        </xsd:choice>
                </xsd:complexType>
        </xsd:element>
</xsd:schema>

    @classmethod
    def should_reset_required(cls, attr: Attr) -> bool:
        """
        Return whether the min occurrences for the attr needs to be reset.

        @Todo figure out if wildcards are supposed to be optional!
        """
        return (
            not attr.is_attribute
            and attr.default is None
            and object in attr.native_types
            and not attr.is_list
        )

[tefra]

A fix on #820 and a further improvement on #828 should take care of this case.

The issue in not with that reset required, that's about wildcards (hint the todo). This issue is about how and when xsdata is calculating the min occurs for choice elements.

It used to be too soon, now I 've moved it later in the flow and made sure if the choice has only one element the min occur restriction doesn't change