Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose actual guest HW description in guest topology #2586

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Expose actual guest HW description in guest topology #2586

wants to merge 3 commits into from

Conversation

happz
Copy link
Collaborator

@happz happz commented Dec 31, 2023 •
edited
Loading

Related to #2402. The patch
bootstraps hardware field in the guest topology content, and populates
it it very basic content. Extending it with more info, e.g. disk or
system, will be task for future patches.

Pull Request Checklist

@happz happz added the step | provision Stuff related to the provision step label Dec 31, 2023
@happz happz added this to the 1.31 milestone Dec 31, 2023
@happz happz changed the title Guest actual hardware in topology Expose actual guest HW description in guest topology Dec 31, 2023
@happz happz added the area | hardware Implementation of hardware requirements label Dec 31, 2023
@happz
Copy link
Collaborator Author

happz commented Jan 2, 2024 •
edited
Loading

/packit build

@happz happz force-pushed the test-data-path-as-property branch from c7ab83a to 0de684c Compare January 3, 2024 22:16
@happz happz marked this pull request as draft January 9, 2024 09:57
@psss psss force-pushed the test-data-path-as-property branch 2 times, most recently from aff4962 to e9ed8b4 Compare January 12, 2024 17:07
Base automatically changed from test-data-path-as-property to main January 12, 2024 18:13
@happz happz removed this from the 1.31 milestone Jan 15, 2024
@thrix thrix mentioned this pull request Jan 19, 2024
Closed
@happz happz force-pushed the guest-actual-hardware-in-topology branch from 0101b5e to 57db8dc Compare March 20, 2024 12:10
@happz happz added this to the 1.33 milestone Mar 20, 2024
@happz happz force-pushed the guest-actual-hardware-in-topology branch 2 times, most recently from c1c72c9 to fbaa944 Compare April 2, 2024 08:32
@happz happz modified the milestones: 1.33, 1.34 Apr 30, 2024
@happz happz force-pushed the guest-actual-hardware-in-topology branch from fbaa944 to 54bedc4 Compare May 21, 2024 09:11
@qcheng-redhat
Copy link
Contributor

qcheng-redhat commented May 30, 2024 •
edited
Loading

In tmt-test-topology-Get-guest-data-default-0.yaml, I get something like this :

guest:
    name: default-0
    role:
    hostname: 127.0.0.1
    hardware:
        arch: == x86_64
        memory: == 8192000 kB
        disk[0].size: == 50 GB

Why == is included? Is it by design ?

@happz
Copy link
Collaborator Author

happz commented May 30, 2024

In tmt-test-topology-Get-guest-data-default-0.yaml, I get something like this :

guest:
    name: default-0
    role:
    hostname: 127.0.0.1
    hardware:
        arch: == x86_64
        memory: == 8192000 kB
        disk[0].size: == 50 GB

Why == is included? Is it by design ?

It is included by default. The value of each requirement consists of the actual value, x86_64, and an optional operator, like = or !=. When the operator is missing, = is the default. arch: x86_64 and arch: = x86_64 are equivalent.

One thing that's wrong though, it should be =, not ==, that I need to fix.

happz added 2 commits June 3, 2024 10:06
@happz
Expose actual guest HW description in guest topology
863f7d1 
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
@happz
squash: fix simplification
72b5974
@happz happz force-pushed the guest-actual-hardware-in-topology branch from 54bedc4 to e5164ab Compare June 3, 2024 08:06
qcheng-redhat
qcheng-redhat reviewed Jun 3, 2024
View reviewed changes
spec/plans/guest-topology.fmf
@@ -113,7 +113,7 @@ description: |
TMT_ROLES[role2]="guestN ..."
...

.. versionadded:: 1.31
.. versionadded:: 1.33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next milestone is 1.34?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it seems we're not going to make that one either :/

Leaving this comment open till the PR gets ready for merge & reviewed.

@happz happz modified the milestones: 1.34, 1.35 Jun 9, 2024
@martinhoyer martinhoyer modified the milestones: 1.35, 1.36 Jul 30, 2024
@happz happz modified the milestones: 1.36, 1.37 Sep 2, 2024
@happz happz removed this from the 1.37 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qcheng-redhat qcheng-redhat qcheng-redhat left review comments

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@frantisekz frantisekz Awaiting requested review from frantisekz frantisekz is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements step | provision Stuff related to the provision step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @qcheng-redhat @martinhoyer