Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add partition as a new hw specification key #1835

Closed
wants to merge 1 commit into from

Conversation

kokesak
Copy link
Contributor

@kokesak kokesak commented Feb 6, 2023

Allow the user to specify the partition parameter. This will create custom partitions on
the disk(s). It should be possible to select the size, mountpoint, filesystem, disk and type of the
partition.

The type can be either classical or LVM (https://www.redhat.com/sysadmin/lvm-vs-partitioning).

Fix: #1243.

Copy link

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor things.

spec/hardware/partition.fmf Outdated Show resolved Hide resolved
tmt/schemas/provision/hardware.yaml Outdated Show resolved Hide resolved
@happz happz added the area | hardware Implementation of hardware requirements label Feb 6, 2023
spec/hardware/partition.fmf Outdated Show resolved Hide resolved
@kokesak kokesak changed the title Draft: Add partition as a new hw specification key Add partition as a new hw specification key Feb 7, 2023
@kokesak kokesak changed the title Add partition as a new hw specification key Draft: Add partition as a new hw specification key Feb 10, 2023
@psss psss requested a review from thrix as a code owner April 4, 2023 14:31
@thrix
Copy link
Collaborator

thrix commented Oct 13, 2023

So there are also some other ideas how to provide a compatible functionality: #2402

I believe directly supporting it in tmt would be more work, the issue above could leave it up to the tests. And might be easier to implement.

@kokesak
Copy link
Contributor Author

kokesak commented Oct 16, 2023

The #2402 seems like a more simple and easy, I'm up for closing this one in favour of #2402

@thrix
Copy link
Collaborator

thrix commented Jan 19, 2024

Closing in favor of #2402 and #2586

@kokesak kokesak requested a review from janhavlin as a code owner March 4, 2024 08:26
@martinhoyer
Copy link
Collaborator

The #2402 seems like a more simple and easy, I'm up for closing this one in favour of #2402

Closing in favor of #2402 and #2586

@martinhoyer martinhoyer closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HW requirements - disk partitions
5 participants