Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable /plans/provision/virtual for pull requests #2558

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 11, 2023

Let's start slowly but surely moving the full test suite execution to pull request testing to catch problems early, prevent the last-minute surprises and speed up the final release tasks.

Pull Request Checklist

  • extend the test coverage

Relates to #2616.

tmt.spec Outdated Show resolved Hide resolved
@psss psss added the test coverage Improvements or additions to test coverage of tmt itself label Dec 11, 2023
@psss psss added this to the 1.31 milestone Dec 11, 2023
@psss psss self-assigned this Dec 11, 2023
@psss
Copy link
Collaborator Author

psss commented Jan 26, 2024

/packit test

@psss
Copy link
Collaborator Author

psss commented Jan 26, 2024

/packit build

@psss
Copy link
Collaborator Author

psss commented Jan 27, 2024

/packit test -i full

@psss psss force-pushed the full-test-virtual branch 2 times, most recently from 635272a to d0b311f Compare January 28, 2024 10:21
@psss psss marked this pull request as ready for review January 29, 2024 09:46
@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i full

@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i provision

1 similar comment
@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i provision

@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i full

@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i full

@psss
Copy link
Collaborator Author

psss commented Jan 29, 2024

/packit test -i provision

@lukaszachy
Copy link
Collaborator

@psss I guess we should extend the 60s timeout to boot the machine.

Let's start slowly but surely moving the full test suite execution
to pull request testing to catch problems early, prevent the
last-minute surprises and speed up the final release tasks.
@psss
Copy link
Collaborator Author

psss commented Jan 30, 2024

@psss I guess we should extend the 60s timeout to boot the machine.

Ack, done in 0bf9527. What confuses me though is the following error:

fail: Package manager "None" is not supported.

Everything else seems to be detected just fine:

qcow: Fedora-Cloud-Base-39-1.5.x86_64.qcow2
name: tmt-8BW-eKlMjbMg
key: /tmp/tmp.BFGJCdl8BW/plan/provision/default-0/id_ecdsa
progress: booting...
ip: 127.0.0.1
port: 10023
multihost name: default-0
arch: x86_64
distro: Fedora Linux 39 (Cloud Edition)
kernel: 6.5.6-300.fc39.x86_64
package manager: unknown
selinux: yes
is superuser: yes

What could cause this? Quite strange, and happens only sometimes.

@psss
Copy link
Collaborator Author

psss commented Jan 30, 2024

/packit test -i full

@psss
Copy link
Collaborator Author

psss commented Jan 30, 2024

/packit test -i provision

@psss
Copy link
Collaborator Author

psss commented Jan 31, 2024

All tests green except for /tests/test/check/avc which failed with some unrelated (arping, dhclient) avc denials:

type=AVC msg=audit(01/31/2024 08:51:40.948:108) : avc:  denied  { append } for  pid=1092 comm=arping path=pipe:[21377] dev="pipefs" ino=21377 scontext=system_u:system_r:netutils_t:s0 tcontext=system_u:system_r:cloud_init_t:s0 tclass=fifo_file permissive=0 
type=AVC msg=audit(01/31/2024 08:51:40.948:109) : avc:  denied  { append } for  pid=1092 comm=arping path=pipe:[21377] dev="pipefs" ino=21377 scontext=system_u:system_r:netutils_t:s0 tcontext=system_u:system_r:cloud_init_t:s0 tclass=fifo_file permissive=0 
type=AVC msg=audit(01/31/2024 08:51:42.969:110) : avc:  denied  { dac_override } for  pid=1107 comm=dhclient-script capability=dac_override  scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:dhcpc_t:s0 tclass=capability permissive=0 
type=AVC msg=audit(01/31/2024 08:51:42.969:111) : avc:  denied  { dac_override } for  pid=1107 comm=dhclient-script capability=dac_override  scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:dhcpc_t:s0 tclass=capability permissive=0 
type=AVC msg=audit(01/31/2024 08:51:45.026:242) : avc:  denied  { dac_override } for  pid=1381 comm=dhclient-script capability=dac_override  scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:dhcpc_t:s0 tclass=capability permissive=0 
type=AVC msg=audit(01/31/2024 08:51:45.026:243) : avc:  denied  { dac_override } for  pid=1381 comm=dhclient-script capability=dac_override  scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:dhcpc_t:s0 tclass=capability permissive=0

Merging.

@psss psss merged commit 42d6e19 into main Jan 31, 2024
18 of 19 checks passed
@psss psss deleted the full-test-virtual branch January 31, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants