Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new prepare plugin for common features #2198

Merged
merged 37 commits into from
Feb 2, 2024

Conversation

idorax
Copy link
Contributor

@idorax idorax commented Jul 11, 2023

The first PR of issue #1062

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • update the specification
  • modify the json schema
  • mention the version
  • include a release note

@idorax idorax marked this pull request as draft July 11, 2023 08:06
@idorax idorax force-pushed the dev-huanli-1062-20230626-prepare-plugin branch 2 times, most recently from 232ab85 to 55c1a3c Compare July 11, 2023 08:27
tmt/steps/prepare/prepare.py Outdated Show resolved Hide resolved
@idorax idorax force-pushed the dev-huanli-1062-20230626-prepare-plugin branch 9 times, most recently from 7a3efc4 to 25c30ae Compare August 1, 2023 09:36
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
@idorax idorax marked this pull request as ready for review August 1, 2023 10:03
@idorax idorax force-pushed the dev-huanli-1062-20230626-prepare-plugin branch 5 times, most recently from 20eff51 to a3516c6 Compare August 14, 2023 14:51
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
@idorax idorax force-pushed the dev-huanli-1062-20230626-prepare-plugin branch from 70785c3 to 8c18d70 Compare August 15, 2023 12:52
@thrix thrix added this to the 1.27 milestone Aug 22, 2023
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
tmt/steps/prepare/feature.py Outdated Show resolved Hide resolved
idorax and others added 25 commits February 2, 2024 12:15
Avoid incorrect matches, such as matching RHEL9 and RHEL99 to RHEL9

Signed-off-by: Vector Li <[email protected]>
* For RHEL 7, 8, 9

Signed-off-by: Vector Li <[email protected]>
* For CentOS Stream 8, 9 and CentOS 7

Signed-off-by: Vector Li <[email protected]>
Signed-off-by: Vector Li <[email protected]>
XXX: Please don't review as the tests are not ready, thanks!

Signed-off-by: Vector Li <[email protected]>
XXX: Please don't review as the tests are not ready, thanks!

Signed-off-by: Vector Li <[email protected]>
* Add ansible playbooks
* Get path of the playbook by getting ID and VERSION_ID from 'guest.facts.os_release_content'

!! Please don't review as it is not ready to call guest.ansible() !!

Signed-off-by: Vector Li <[email protected]>
* Remove class Distro and the related code

Signed-off-by: Vector Li <[email protected]>
Extend it to support CentOS 7 and RHEL 7

Signed-off-by: Vector Li <[email protected]>
Signed-off-by: Vector Li <[email protected]>
@psss psss force-pushed the dev-huanli-1062-20230626-prepare-plugin branch from 56a326b to e968256 Compare February 2, 2024 11:18
@psss
Copy link
Collaborator

psss commented Feb 2, 2024

/packit test -i full

@psss
Copy link
Collaborator

psss commented Feb 2, 2024

/packit test -i provision

@psss psss merged commit d5b5a76 into main Feb 2, 2024
18 of 19 checks passed
@psss psss deleted the dev-huanli-1062-20230626-prepare-plugin branch February 2, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step | prepare Stuff related to the prepare step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a new prepare plugin for common features
6 participants