Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2006 #2008

Closed
wants to merge 1 commit into from
Closed

Fix #2006 #2008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tmt/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,14 +1556,20 @@ def _lint_discover(self) -> bool:

return correct

@staticmethod
def _lint_discover_fmf(discover: tmt.steps._RawStepData) -> bool:
def _lint_discover_fmf(self, discover: tmt.steps._RawStepData) -> bool:
""" Lint fmf discover method """
# Validate remote id and translate to human readable errors
fmf_id_data = cast(
_RawFmfId,
{key: value for key, value in discover.items() if key in ['url', 'ref', 'path']}
)
# If no specific fmf is passed, use the current context
if not fmf_id_data:
fmf_id_data = dict(
url=self.fmf_id.url,
ref=self.fmf_id.ref,
path=self.fmf_id.path,
)

# Skipping `name` on purpose - that belongs to the whole step,
# it's not treated as part of fmf id.
Expand Down