Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2006 #2008

Closed
wants to merge 1 commit into from
Closed

Fix #2006 #2008

wants to merge 1 commit into from

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Apr 19, 2023

Default to current context if lint discover is not specified. Can someone confirm that this is the appropriate default behaviour?

Also I did not check if there is a similar need for other lint commands

Fixes: #2006

Default to current context if lint discover is not specified

Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 5, 2023

Can someone check this PR and/or point to where I should make relevant tests for this?

@happz
Copy link
Collaborator

happz commented May 5, 2023

@LecrisUT Hi, could you check whether the issue manifests with this lint refactoring, whether it's affected (or maybe even fixed? :) ? #1851

A good place for a test would be under https://github.com/teemtee/tmt/tree/main/tests/plan/lint - metadata would come into the data directory, and necessary commands in test.sh.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 5, 2023

@happz, tanks for pointing me to that one. Indeed the lint test pass with that. I will close this PR in favor of that. Could you link a fixes #2006 over there?

@happz
Copy link
Collaborator

happz commented May 5, 2023

Absolutely, thank you.

@LecrisUT LecrisUT deleted the fix/2006 branch May 5, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmt lint fails with fmf path not in root
2 participants