Json config #103
Open
Json config #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jkleiber
reviewed
Feb 13, 2024
|
@minhnguyenbhs this looks good to me. Before approving/merging, I'd like us to update the branch and test this on the robot |
| break; | ||
| default: | ||
| t = null; | ||
| break; |
There was a problem hiding this comment.
Hey this is a bit of a nitpick but can you send a warning through the driver station and set an empty trigger when a non-existent button is configured? I would rather not have to null-check button assignments in RobotContainer or risk crashing over a heat-of-the-moment typo.
| break; | ||
| default: | ||
| t = null; | ||
| break; |
|
|
||
| if (controllers.get(p.get("controller")) == null) { | ||
| povList.put((String) p.get("command"), () -> 0); | ||
| } else |
There was a problem hiding this comment.
...and add a warning here.
There was a problem hiding this comment.
Okay! I'll fix this as soon as possible! Is the robot ready yet?
There was a problem hiding this comment.
We should get it on Saturday
… verify that everything else is actually correct :D
BlueCricket6
force-pushed
the
json-config
branch
from
4c4f570 to
81540e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested it out with an actual gamepad yet, but it appears to be working with simulation joysticks maybe? I'll get to the rest of the testing stuff on Wednesday, but in the meantime what do you think about the layout and everything?