fix(worker): wait fetched jobs to be processed when closing #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
approved these changes
Feb 7, 2025
tests/test_events.ts
Outdated
| @@ -29,6 +29,7 @@ describe('events', function () { | |||
|
|
|||
| beforeEach(async function () { | |||
| queueName = `test-${v4()}`; | |||
| console.log('queueName', queueName); | |||
There was a problem hiding this comment.
this line can be removed
roggervalf
changed the title
roggervalf
deleted the
fix/wait-fetched-jobs-to-be-processed-when-closing
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
## [5.40.1](v5.40.0...v5.40.1) (2025-02-07) ### Bug Fixes * **worker:** wait fetched jobs to be processed when closing ([#3059](#3059)) ([d4de2f5](d4de2f5))
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This change is necessary to avoid possible stalled jobs when closing a worker, since the close operation just stops processing the jobs that may be already in active status but have not yet started to be processed.
How
Making sure that we wait for the jobs to complete before resolving the close promise.
Additional Notes (Optional)
Any extra info here.