fix(worker): process job when closing and it was moved to active #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Feb 2, 2025
| @@ -819,7 +826,7 @@ will never work with more accuracy than 1ms. */ | |||
| fetchNextCallback = () => true, | |||
| jobsInProgress: Set<{ job: Job; ts: number }>, | |||
| ): Promise<void | Job<DataType, ResultType, NameType>> { | |||
| if (!job || this.closing || this.paused) { | |||
| if (!job) { | |||
There was a problem hiding this comment.
not needed, as the signature of this method already guarantees that the job cannot be undefined or null
| @@ -88,7 +88,7 @@ else | |||
| end | |||
| end | |||
|
|
|||
| local deduplicationJobId = deduplicateJob(args[1], opts['de'], | |||
| local deduplicationJobId = deduplicateJob(opts['de'], | |||
There was a problem hiding this comment.
Unused variable, not a fix, just re formatting
| ]] | ||
|
|
||
| local function deduplicateJob(prefixKey, deduplicationOpts, jobId, deduplicationKey, eventsKey, maxEvents) | ||
| local function deduplicateJob(deduplicationOpts, jobId, deduplicationKey, eventsKey, maxEvents) |
There was a problem hiding this comment.
this seems to be an unrelated fix.
|
Closed in favor of #3059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Any extra info here.