Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement last interaction tracker #2716

Merged

Conversation

Sumit112192
Copy link
Contributor

📝 Description

Type: 🚀 feature

This continue is based on the work of the previous PR #2650. Also, PR #2714 should be merged first.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 105 lines in your changes missing coverage. Please review.

Project coverage is 36.57%. Comparing base (c107f27) to head (7cdca9b).
Report is 4 commits behind head on master.

Files Patch % Lines
...transport/montecarlo/tests/test_rpacket_tracker.py 38.09% 39 Missing ⚠️
...rlo/tests/test_rpacket_last_interaction_tracker.py 56.45% 27 Missing ⚠️
tardis/transport/montecarlo/packet_trackers.py 29.41% 12 Missing ⚠️
...dis/visualization/tools/tests/test_rpacket_plot.py 33.33% 10 Missing ⚠️
tardis/transport/montecarlo/single_packet_loop.py 12.50% 7 Missing ⚠️
...ardis/transport/montecarlo/montecarlo_main_loop.py 33.33% 6 Missing ⚠️
tardis/transport/montecarlo/base.py 33.33% 2 Missing ⚠️
tardis/transport/montecarlo/configuration/base.py 50.00% 1 Missing ⚠️
tardis/visualization/tools/rpacket_plot.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
+ Coverage   36.47%   36.57%   +0.10%     
==========================================
  Files         183      184       +1     
  Lines       14664    14765     +101     
==========================================
+ Hits         5348     5401      +53     
- Misses       9316     9364      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sumit112192 Sumit112192 marked this pull request as ready for review July 18, 2024 08:33
@Sumit112192
Copy link
Contributor Author

@wkerzendorf @andrewfullard Please review.

@Sumit112192 Sumit112192 changed the title Implement last interaction tracker [PR# 2714 should be merged first] Implement last interaction tracker Jul 18, 2024
@Sumit112192 Sumit112192 changed the title [PR# 2714 should be merged first] Implement last interaction tracker Implement last interaction tracker Jul 18, 2024
@Sumit112192
Copy link
Contributor Author

Profiling:
Master Branch
Screenshot from 2024-07-18 14-13-45

ImplementLastInteractionTracker Branch
Screenshot from 2024-07-18 14-14-33

Memory usage has gone down even with the LastInteractionTracker initialization.

@andrewfullard andrewfullard merged commit b8ec53f into tardis-sn:master Jul 19, 2024
14 of 15 checks passed
@Sumit112192 Sumit112192 deleted the ImplementLastInteractionTracker branch September 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants