restructure of rpacket_tracker #2714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumit112192
changed the title
|
@wkerzendorf @andrewfullard Please review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
==========================================
+ Coverage 36.47% 36.49% +0.02%
==========================================
Files 183 183
Lines 14664 14685 +21
==========================================
+ Hits 5348 5359 +11
- Misses 9316 9326 +10 ☔ View full report in Codecov by Sentry. |
Sumit112192
force-pushed
the
FixRPacketTracker
branch
from
df590fd
to
1368603
Compare
|
Profiling: |
andrewfullard
approved these changes
Jul 18, 2024
| ------- | ||
| simulation object with track_rpacket enabled | ||
| """ | ||
| config_rpacket_tracking.montecarlo.iterations = 3 |
There was a problem hiding this comment.
Do we need 3 iterations for the test to be useful?
There was a problem hiding this comment.
I don't think so. But it shouldn't take too much time.
|
Completet as PR #2716 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🎢
infrastructureandrestructureThis PR restructures the rpacket_tracker code to initialize only when the track_rpacket flag is set. Apart from that, I will also add tests for the rpacket_tracker and change how it registers an interaction.