Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

PI refactor #138

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

update

2cb3e17
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

PI refactor #138

update
2cb3e17
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy failed Sep 25, 2023 in 0s

Clippy

9 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 0
Note 0
Help 0

Versions

  • rustc 1.71.0-nightly (7f94b314c 2023-04-23)
  • cargo 1.71.0-nightly (de80432f0 2023-04-21)
  • clippy 0.1.70 (7f94b31 2023-04-23)

Annotations

Check failure on line 1392 in zkevm-circuits/src/circuit_tools/constraint_builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused `std::result::Result` that must be used

error: unused `std::result::Result` that must be used
    --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65
     |
1381 |       ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{
     |  _________________________________________________________________^
1382 | |         use halo2_proofs::circuit::Value;
1383 | |         let description =
1384 | |             $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value));
...    |
1391 | |         )
1392 | |     }};
     | |_____^
     |
    ::: zkevm-circuits/src/taiko_pi_circuit.rs:457:17
     |
457  |                   assign!(region, self.block_hash.2, 0 => evidence.assignment_acc(BLOCK_HASH, evm_word));
     |                   -------------------------------------------------------------------------------------- in this macro invocation
     |
     = note: this `Result` may be an `Err` variant, which should be handled
     = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `let _ = ...` to ignore the resulting value
     |
1381 |     ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = {
     |                                                                 +++++++

Check failure on line 1392 in zkevm-circuits/src/circuit_tools/constraint_builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused `std::result::Result` that must be used

error: unused `std::result::Result` that must be used
    --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65
     |
1381 |       ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{
     |  _________________________________________________________________^
1382 | |         use halo2_proofs::circuit::Value;
1383 | |         let description =
1384 | |             $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value));
...    |
1391 | |         )
1392 | |     }};
     | |_____^
     |
    ::: zkevm-circuits/src/taiko_pi_circuit.rs:456:17
     |
456  |                   assign!(region, self.block_hash.0, 0 => (evidence.block_context.number).as_u64().scalar());
     |                   ------------------------------------------------------------------------------------------ in this macro invocation
     |
     = note: this `Result` may be an `Err` variant, which should be handled
     = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `let _ = ...` to ignore the resulting value
     |
1381 |     ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = {
     |                                                                 +++++++

Check failure on line 1392 in zkevm-circuits/src/circuit_tools/constraint_builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused `std::result::Result` that must be used

error: unused `std::result::Result` that must be used
    --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65
     |
1381 |       ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{
     |  _________________________________________________________________^
1382 | |         use halo2_proofs::circuit::Value;
1383 | |         let description =
1384 | |             $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value));
...    |
1391 | |         )
1392 | |     }};
     | |_____^
     |
    ::: zkevm-circuits/src/taiko_pi_circuit.rs:455:17
     |
455  |                   assign!(region, self.parent_hash.2, 0 => evidence.assignment_acc(PARENT_HASH, evm_word));
     |                   ---------------------------------------------------------------------------------------- in this macro invocation
     |
     = note: this `Result` may be an `Err` variant, which should be handled
     = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `let _ = ...` to ignore the resulting value
     |
1381 |     ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = {
     |                                                                 +++++++

Check failure on line 1392 in zkevm-circuits/src/circuit_tools/constraint_builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused `std::result::Result` that must be used

error: unused `std::result::Result` that must be used
    --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65
     |
1381 |       ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{
     |  _________________________________________________________________^
1382 | |         use halo2_proofs::circuit::Value;
1383 | |         let description =
1384 | |             $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value));
...    |
1391 | |         )
1392 | |     }};
     | |_____^
     |
    ::: zkevm-circuits/src/taiko_pi_circuit.rs:454:17
     |
454  |                   assign!(region, self.parent_hash.0, 0 => (evidence.block_context.number - 1).as_u64().scalar());
     |                   ----------------------------------------------------------------------------------------------- in this macro invocation
     |
     = note: this `Result` may be an `Err` variant, which should be handled
     = note: `-D unused-must-use` implied by `-D warnings`
     = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `let _ = ...` to ignore the resulting value
     |
1381 |     ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = {
     |                                                                 +++++++

Check failure on line 254 in zkevm-circuits/src/circuit_tools/cell_manager.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

field assignment outside of initializer for an instance created with Default::default()

error: field assignment outside of initializer for an instance created with Default::default()
   --> zkevm-circuits/src/circuit_tools/cell_manager.rs:254:9
    |
254 |         cm.height_limit = max_height;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `CellManager::<F, C> { height_limit: max_height, ..Default::default() }` and removing relevant reassignments
   --> zkevm-circuits/src/circuit_tools/cell_manager.rs:253:9
    |
253 |         let mut cm = CellManager::default();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
    = note: `-D clippy::field-reassign-with-default` implied by `-D warnings`

Check failure on line 538 in zkevm-circuits/src/circuit_tools/constraint_builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

this function has too many arguments (8/7)

error: this function has too many arguments (8/7)
   --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:529:5
    |
529 | /     pub(crate) fn add_lookup(
530 | |         &mut self,
531 | |         description: &'static str,
532 | |         tag: C,
...   |
537 | |         dyn_path: bool,
538 | |     ) {
    | |______^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`

Check failure on line 19 in zkevm-circuits/src/taiko_pi_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `LookupTable`

error: unused import: `LookupTable`
  --> zkevm-circuits/src/taiko_pi_circuit.rs:19:83
   |
19 |     table::{byte_table::ByteTable, BlockContextFieldTag, BlockTable, KeccakTable, LookupTable},
   |                                                                                   ^^^^^^^^^^^

Check failure on line 16 in zkevm-circuits/src/taiko_pi_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `ExprVec`

error: unused import: `ExprVec`
  --> zkevm-circuits/src/taiko_pi_circuit.rs:16:49
   |
16 |         constraint_builder::{ConstraintBuilder, ExprVec, RLCable, TO_FIX},
   |                                                 ^^^^^^^

Check failure on line 9 in zkevm-circuits/src/circuit_tools/memory.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `itertools::Itertools`

error: unused import: `itertools::Itertools`
 --> zkevm-circuits/src/circuit_tools/memory.rs:9:5
  |
9 | use itertools::Itertools;
  |     ^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`