Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

PI refactor

PI refactor #563

Triggered via pull request September 25, 2023 13:01
@CeciliaZ030CeciliaZ030
synchronize #138
Status Success
Total duration 15s
Artifacts

labeler.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 1 warning
unused `std::result::Result` that must be used: zkevm-circuits/src/circuit_tools/constraint_builder.rs#L1381
error: unused `std::result::Result` that must be used --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65 | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{ | _________________________________________________________________^ 1382 | | use halo2_proofs::circuit::Value; 1383 | | let description = 1384 | | $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value)); ... | 1391 | | ) 1392 | | }}; | |_____^ | ::: zkevm-circuits/src/taiko_pi_circuit.rs:457:17 | 457 | assign!(region, self.block_hash.2, 0 => evidence.assignment_acc(BLOCK_HASH, evm_word)); | -------------------------------------------------------------------------------------- in this macro invocation | = note: this `Result` may be an `Err` variant, which should be handled = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info) help: use `let _ = ...` to ignore the resulting value | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = { | +++++++
unused `std::result::Result` that must be used: zkevm-circuits/src/circuit_tools/constraint_builder.rs#L1381
error: unused `std::result::Result` that must be used --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65 | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{ | _________________________________________________________________^ 1382 | | use halo2_proofs::circuit::Value; 1383 | | let description = 1384 | | $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value)); ... | 1391 | | ) 1392 | | }}; | |_____^ | ::: zkevm-circuits/src/taiko_pi_circuit.rs:456:17 | 456 | assign!(region, self.block_hash.0, 0 => (evidence.block_context.number).as_u64().scalar()); | ------------------------------------------------------------------------------------------ in this macro invocation | = note: this `Result` may be an `Err` variant, which should be handled = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info) help: use `let _ = ...` to ignore the resulting value | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = { | +++++++
unused `std::result::Result` that must be used: zkevm-circuits/src/circuit_tools/constraint_builder.rs#L1381
error: unused `std::result::Result` that must be used --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65 | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{ | _________________________________________________________________^ 1382 | | use halo2_proofs::circuit::Value; 1383 | | let description = 1384 | | $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value)); ... | 1391 | | ) 1392 | | }}; | |_____^ | ::: zkevm-circuits/src/taiko_pi_circuit.rs:455:17 | 455 | assign!(region, self.parent_hash.2, 0 => evidence.assignment_acc(PARENT_HASH, evm_word)); | ---------------------------------------------------------------------------------------- in this macro invocation | = note: this `Result` may be an `Err` variant, which should be handled = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info) help: use `let _ = ...` to ignore the resulting value | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = { | +++++++
unused `std::result::Result` that must be used: zkevm-circuits/src/circuit_tools/constraint_builder.rs#L1381
error: unused `std::result::Result` that must be used --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:1381:65 | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {{ | _________________________________________________________________^ 1382 | | use halo2_proofs::circuit::Value; 1383 | | let description = 1384 | | $crate::concat_with_preamble!(stringify!($cell), " => ", stringify!($value)); ... | 1391 | | ) 1392 | | }}; | |_____^ | ::: zkevm-circuits/src/taiko_pi_circuit.rs:454:17 | 454 | assign!(region, self.parent_hash.0, 0 => (evidence.block_context.number - 1).as_u64().scalar()); | ----------------------------------------------------------------------------------------------- in this macro invocation | = note: this `Result` may be an `Err` variant, which should be handled = note: `-D unused-must-use` implied by `-D warnings` = note: this error originates in the macro `assign` (in Nightly builds, run with -Z macro-backtrace for more info) help: use `let _ = ...` to ignore the resulting value | 1381 | ($region:expr, $cell:expr, $offset:expr => $value:expr) => {let _ = { | +++++++
field assignment outside of initializer for an instance created with Default::default(): zkevm-circuits/src/circuit_tools/cell_manager.rs#L254
error: field assignment outside of initializer for an instance created with Default::default() --> zkevm-circuits/src/circuit_tools/cell_manager.rs:254:9 | 254 | cm.height_limit = max_height; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `CellManager::<F, C> { height_limit: max_height, ..Default::default() }` and removing relevant reassignments --> zkevm-circuits/src/circuit_tools/cell_manager.rs:253:9 | 253 | let mut cm = CellManager::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `-D clippy::field-reassign-with-default` implied by `-D warnings`
this function has too many arguments (8/7): zkevm-circuits/src/circuit_tools/constraint_builder.rs#L529
error: this function has too many arguments (8/7) --> zkevm-circuits/src/circuit_tools/constraint_builder.rs:529:5 | 529 | / pub(crate) fn add_lookup( 530 | | &mut self, 531 | | description: &'static str, 532 | | tag: C, ... | 537 | | dyn_path: bool, 538 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings`
unused import: `LookupTable`: zkevm-circuits/src/taiko_pi_circuit.rs#L19
error: unused import: `LookupTable` --> zkevm-circuits/src/taiko_pi_circuit.rs:19:83 | 19 | table::{byte_table::ByteTable, BlockContextFieldTag, BlockTable, KeccakTable, LookupTable}, | ^^^^^^^^^^^
unused import: `ExprVec`: zkevm-circuits/src/taiko_pi_circuit.rs#L16
error: unused import: `ExprVec` --> zkevm-circuits/src/taiko_pi_circuit.rs:16:49 | 16 | constraint_builder::{ConstraintBuilder, ExprVec, RLCable, TO_FIX}, | ^^^^^^^
unused import: `itertools::Itertools`: zkevm-circuits/src/circuit_tools/memory.rs#L9
error: unused import: `itertools::Itertools` --> zkevm-circuits/src/circuit_tools/memory.rs:9:5 | 9 | use itertools::Itertools; | ^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`
triage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/labeler@v3. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/