Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (node-analyzer): add sslVerifyCertificate=false #2148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore (node-analyzer): add sslVerifyCertificate=false #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e336da9
DOC-3689
radhikapc Feb 10, 2025
257969f
Update Chart.yaml
radhikapc Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/node-analyzer/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: node-analyzer
description: Sysdig Node Analyzer
# currently matching Sysdig's appVersion 1.14.34
version: 1.34.5
version: 1.34.6
appVersion: 12.9.2
keywords:
- monitoring
Expand Down
3 changes: 2 additions & 1 deletion charts/node-analyzer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ helm install sysdig-agent --namespace sysdig-agent --create-namespace \
--set nodeAnalyzer.secure.vulnerabilityManagement.newEngineOnly=true \
--set global.kspm.deploy=true \
--set nodeAnalyzer.nodeAnalyzer.benchmarkRunner.deploy=false \
--set nodeAnalyzer.nodeAnalyzer.hostScanner.deploy=true
--set nodeAnalyzer.nodeAnalyzer.hostScanner.deploy=true \
--set nodeAnalyzer.nodeAnalyzer.sslVerifyCertificate=false \
Copy link
Collaborator

@airadier airadier Feb 10, 2025 •
edited by mavimo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the sslVerifyCertificate be added to the table below, and not to the example?

But the value is there. Is it just missing the default value:
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default value? I thought we need to add SSL verification to the example

Copy link
Collaborator

@airadier airadier Feb 11, 2025 •
edited by mavimo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to the example is ok. But the default value is missing. The default value AFAIK is "true" (verify certificate by default), or maybe it is empty achieving the same effect

--set global.clusterConfig.name=<CLUSTER_NAME> \
sysdig/sysdig-deploy
```
Expand Down
Loading