chore (node-analyzer): add sslVerifyCertificate=false #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests
radhikapc
changed the title
radhikapc
changed the title
radhikapc
changed the title
airadier
reviewed
Feb 10, 2025
| @@ -40,7 +40,8 @@ helm install sysdig-agent --namespace sysdig-agent --create-namespace \ | |||
| --set nodeAnalyzer.secure.vulnerabilityManagement.newEngineOnly=true \ | |||
| --set global.kspm.deploy=true \ | |||
| --set nodeAnalyzer.nodeAnalyzer.benchmarkRunner.deploy=false \ | |||
| --set nodeAnalyzer.nodeAnalyzer.hostScanner.deploy=true | |||
| --set nodeAnalyzer.nodeAnalyzer.hostScanner.deploy=true \ | |||
| --set nodeAnalyzer.nodeAnalyzer.sslVerifyCertificate=false \ | |||
There was a problem hiding this comment.
Shouldn't the sslVerifyCertificate be added to the table below, and not to the example?
But the value is there. Is it just missing the default value:
There was a problem hiding this comment.
What is the default value? I thought we need to add SSL verification to the example
There was a problem hiding this comment.
Adding to the example is ok. But the default value is missing. The default value AFAIK is "true" (verify certificate by default), or maybe it is empty achieving the same effect
mavimo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
feat(agent,node-analyzer,sysdig-deploy):)