feat: expose container resources for ske operator #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richcooper95
force-pushed
the
feat/expose-ske-operator-resources
branch
from
5ff0380 to
101aa4e
Compare
ChunyiLyu
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
LGTM. May I suggesting making sure the resource request and limit are the same in: https://github.com/syntasso/enterprise-kratix/blob/main/ske-operator/config/manager/manager.yaml#L85-L93 as well?
richcooper95
force-pushed
the
feat/expose-ske-operator-resources
branch
from
101aa4e to
9537f2a
Compare
richcooper95
force-pushed
the
feat/expose-ske-operator-resources
branch
from
9537f2a to
2409949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: #24