Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

add documentation about phpcr_document. fix #346 #347

Merged
merged 1 commit into from
Dec 16, 2013
Merged

add documentation about phpcr_document. fix #346 #347

merged 1 commit into from
Dec 16, 2013

Conversation

dbu
Copy link
Member

@dbu dbu commented Dec 10, 2013

Q A
New docs? no
Doc fix? yes
Applies to all
Fixed tickets #346

``sonata_type_collection``. This form type allows to edit related
documents (references as well as children) inline and also to create
and remove them on the fly.

phpcr_odm_reference_collection
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elHornair git blame says you worked on this type. do you remember what it was able to do? i wonder if it makes sense to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure anymore, but I think we used it to edit a collection of n references to phpcr nodes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodes or documents? i think its based on documents.
@lsmith77 do you remember anything about this?

i grepped through our codebases and the cmf sandbox and found it used nowhere...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope :-/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbu
Copy link
Member Author

dbu commented Dec 11, 2013

@wouterj if we deprecate the other form type, should we simply remove it from the doc or add information that its deprecated?
i will do a new PR for that, so this PR can be merged if the doc of phpcr_document is fine as is.

@wouterj
Copy link
Member

wouterj commented Dec 11, 2013

if we deprecate the other form type, should we simply remove it from the doc or add information that its deprecated?

We should leave the form type in there, until it's removed. We only need to add a .. caution saying it's deprecated.

i will do a new PR for that, so this PR can be merged if the doc of phpcr_document is fine as is.

Feel free to hit the merge button here

dbu added a commit that referenced this pull request Dec 16, 2013
add documentation about phpcr_document. fix #346
@dbu dbu merged commit e0195dd into master Dec 16, 2013
@dbu dbu deleted the form-type branch December 16, 2013 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants