deprecate the phpcr_odm_reference_collection form type in favor of phpcr_document #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +23,7 @@ class PHPCRODMReferenceCollectionType extends AbstractType | |||
| */ | |||
| function __construct(DocumentManager $dm) | |||
| { | |||
| trigger_error('This form type is deprecated in favor of phpcr_document. If you think this is an error, please contact us and explain. We where not able to figure out what this type is good for.', E_WARNING); | |||
There was a problem hiding this comment.
you should triggering it in buildForm, i.e. when the type is used, rather than in __construct (which would trigger it if you register it non-lazily even without using it).
There was a problem hiding this comment.
thanks, was not aware of this. fixed now.
|
alright, merge this? |
|
sounds good .. can we add UUID support to phpcr_document? |
|
i would guess so - although i don't know how many classes we would need to extend for that. as i did not manage to get the reference_collection form type to work at all, i think we lose nothing be deprecating it here. but i created an issue for uuid support: #103. |
dbu
added a commit
that referenced
this pull request
Dec 16, 2013
…type deprecate the phpcr_odm_reference_collection form type in favor of phpcr_document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
afaict this form type does not even work (anymore?) and it seems the only thing it does that phpcr_document can not do better already is to allow to use the UUID instead of the path (as path is the primary id for phpcr-odm). not sure if that is worth anything - but if so we should port that into the phpcr_document type.
if we deprecate this now, would we drop it in version 1.2? i think this is not even usable, but i might be wrong so we could use the deprecation to hear from users.