fix: don't set mode option on workdir bind mount #3718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runc v1.2+ checks that a bind mount definition doesn't have any fs-specific options set on it, as these will not be applied. We are erroneously setting `mode-777` on a `--workdir` bind mount prior to this PR, so `--workdir` causes a failure where runc v1.2+ is installed, and crun is not installed. Remove the incorrect option. It likely came from a copy/paste of a `tmpfs` definition, and has never been correct/effective here. Fixes sylabs#3716
tri-adam
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
runc v1.2+ checks that a bind mount definition doesn't have any fs-specific options set on it, as these will not be applied.
We are erroneously setting
mode=777on a--workdirbind mount prior to this PR, so--workdircauses a failure where runc v1.2+ is installed, and crun is not installed.Remove the incorrect option. It likely came from a copy/paste of a
tmpfsdefinition, and has never been correct/effective here.This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).