Skip to content

Commit e553b8f

Browse files
committed
fix: don't set mode option on workdir bind mount
runc v1.2+ checks that a bind mount definition doesn't have any fs-specific options set on it, as these will not be applied. We are erroneously setting `mode-777` on a `--workdir` bind mount prior to this PR, so `--workdir` causes a failure where runc v1.2+ is installed, and crun is not installed. Remove the incorrect option. It likely came from a copy/paste of a `tmpfs` definition, and has never been correct/effective here. Fixes #3716
1 parent 08da20f commit e553b8f

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

internal/pkg/runtime/launcher/oci/mounts_linux.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ func (l *Launcher) addTmpMounts(mounts *[]specs.Mount) error {
140140
opts := []string{
141141
"rbind",
142142
"relatime",
143-
"mode=777",
144143
}
145144
if !l.cfg.AllowSUID {
146145
opts = append(opts, "nosuid")

0 commit comments

Comments
 (0)