Support building only tests using SwiftPM #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
allevato,
bnbarham and
shawnhyam
as code owners
This allows us to build everything required for the executable using CMake and only the test targets using SwiftPM, enabling us to run tests on Windows from build.ps1 with minimal overhead.
ahoppen
force-pushed
the
windows-build
branch
from
bf232a2
to
1babba4
Compare
allevato
approved these changes
Oct 12, 2024
ahoppen
added a commit
that referenced
this pull request
Oct 14, 2024
Allow building against a single dynamic swift-syntax library 🚥#851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift#76900
This allows us to build everything required for the executable using CMake and only the test targets using SwiftPM, enabling us to run tests on Windows from build.ps1 with minimal overhead.
Compared to #841, this allows us to re-use
SwiftFormat.dllfrom the CMake build on Windows, reducing the amount of code that needs to get built and testing the libraries that will actually be shipped in the toolchain.