Support building only tests using SwiftPM #1768
Merged
+444
−415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
build-tests-only
branch
from
1fdc196
to
f2fa6e4
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
build-tests-only
branch
from
f2fa6e4
to
3ce1a32
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This allows us to build everything required for the executable using CMake and only the test targets using SwiftPM, enabling us to run tests on Windows from build.ps1 with minimal overhead.
ahoppen
force-pushed
the
build-tests-only
branch
from
3ce1a32
to
24488cc
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Oct 18, 2024
| @@ -1,4 +1,4 @@ | |||
| add_compile_options("$<$<COMPILE_LANGUAGE:Swift>:SHELL:-package-name SourceKitLSP>") | |||
| add_compile_options("$<$<COMPILE_LANGUAGE:Swift>:SHELL:-package-name sourcekit_lsp>") | |||
There was a problem hiding this comment.
When building the tests using SwiftPM, this is the package name that SwiftPM will chose and it means that we can use declarations at the package level from the modules built using CMake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to build everything required for the executable using CMake and only the test targets using SwiftPM, enabling us to run tests on Windows from build.ps1 with minimal overhead.
Analogous to swiftlang/swift-format#851