fix bug #1359
Merged
fix bug #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrumley
requested review from
notoriaga,
silverjam and
jungleraptor
as code owners
silverjam
approved these changes
Aug 26, 2023
|
Libsbp automerge unfortunately only blocks on a few required checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
So I just put up a quick PR earlier thinking i had fixed the new lints, and set to auto-merge figuring i could push up new fixes if it didn't work. But what happened was the rust lint stage actually failed and it still let automerge go through!
This PR actually fixes those bugs, and I think the branch protection rules of libsbp need to be reviewed.