Skip to content

Commit

Permalink
fix bug (#1359)
Browse files Browse the repository at this point in the history
# Description

@swift-nav/devinfra

So I just put up a quick PR earlier thinking i had fixed the new lints,
and set to auto-merge figuring i could push up new fixes if it didn't
work. But what happened was the rust lint stage actually failed and it
still let automerge go through!

This PR actually fixes those bugs, and I think the branch protection
rules of libsbp need to be reviewed.
  • Loading branch information
pcrumley authored Aug 26, 2023
1 parent 7dd61a9 commit b0fa189
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions rust/sbp/src/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,10 @@ mod tests {
let timeout_duration = Duration::from_secs(2);
let now = Instant::now();
let mut messages = iter_messages_with_timeout(rdr, timeout_duration);
assert_eq!(messages.next().unwrap(), Err(Error::IoError(_)));
assert!(matches!(
messages.next().unwrap().unwrap_err(),
Error::IoError(_)
));
assert!(now.elapsed() >= timeout_duration);
}

Expand Down Expand Up @@ -494,7 +497,7 @@ mod tests {
let data = vec![0u8; 1000];
let mut bytes = BytesMut::from(&data[..]);
assert_eq!(bytes.len(), 1000);
assert_eq!(FramerImpl.decode(&mut bytes).unwrap(), None);
assert!(FramerImpl.decode(&mut bytes).unwrap().is_none());
}

#[test]
Expand Down

0 comments on commit b0fa189

Please sign in to comment.