linked on the pop-up to Terms of Service and Privacy Policy now works #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes in PrivacyPolicy Page and link it to the popup window
linked the Term and conditions and PrivacyPolicy Page to the Popup window
updated the page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @himasnhu018! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi there! This issue is still open. We are looking forward to your response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Format
PR Title
Issue #595 : links on the pop-up to Terms of Service and Privacy Policy do not work solved
Type of PR
Add X in the box to specify the improvement type.
Bug fix
Feature enhancement
Documentation update
Other (specify): ___________
Description
This pull request aims to fix the non-functional links to the Terms of Service and Privacy Policy in the popup window of the index.html page. The Privacy Policy link is now properly directed to the PrivacyPolicy.html page, ensuring users can access important information regarding their data and usage policies directly from the popup.
Screenshots / Videos (if applicable)
Before:
The popup contained links to the Terms of Service and Privacy Policy, but they were inactive and did not lead to the respective pages, leading to confusion among users seeking more information.
After:
The popup now features clickable links that correctly navigate users to the Terms of Service and Privacy Policy pages. Users can seamlessly access these critical documents, enhancing user experience and transparency.
Checklist
Add X in the box to specify.
I have performed a self-review of my code.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.
Additional Context
The main challenge faced was ensuring the links within the popup correctly referenced the appropriate HTML pages without disrupting existing functionality. Careful attention was given to maintain the styling and responsiveness of the popup while ensuring the links are user-friendly. These improvements not only provide direct access to policies but also enhance the overall user experience on the website.
Thank you for reviewing my pull request!