Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] : links on the pop-up to Terms of Service and Privacy Policy do not work #595

Open
KAUSHIKRM-36 opened this issue Oct 19, 2024 · 11 comments

Comments

@KAUSHIKRM-36
Copy link
Contributor

Screenshot 2024-10-20 004829

@swaraj-das please assign me this task under
Gssoc-extd 24
Hacktoberfest 24
at level 1

Copy link

Congratulations, @KAUSHIKRM-36! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@KAUSHIKRM-36
Copy link
Contributor Author

@swaraj-das please assign me this task , i really want to contribute to this project

@Sharibraza
Copy link

Sharibraza commented Oct 19, 2024

/assign

@himasnhu018
Copy link

I would like to contribute on this. please assign me that issue.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @himasnhu018, @Sharibraza, @KAUSHIKRM-36

@KAUSHIKRM-36
Copy link
Contributor Author

@KAUSHIKRM-36
Copy link
Contributor Author

@swaraj-das is there some issue?
Screenshot 2024-10-20 134043
its showing some startup failure?

@KAUSHIKRM-36
Copy link
Contributor Author

also please add the level label

@himasnhu018
Copy link

I added the required changes for the opened issue. Kindly go through my changes and cross check them.
It's my pleasure to contribute for your team.
Thanks you.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @himasnhu018, @Sharibraza, @KAUSHIKRM-36

@himasnhu018
Copy link

PR Title
Issue #595 and #627 : links on the pop-up to Terms of Service and Privacy Policy do not work solved
Type of PR
Add X in the box to specify the improvement type.
Bug fix
Feature enhancement
Documentation update
Other (specify): ___________
Description
This pull request aims to fix the non-functional links to the Terms of Service and Privacy Policy in the popup window of the index.html page. The Privacy Policy link is now properly directed to the PrivacyPolicy.html page, ensuring users can access important information regarding their data and usage policies directly from the popup.

Screenshots / Videos (if applicable)
Before:

The popup contained links to the Terms of Service and Privacy Policy, but they were inactive and did not lead to the respective pages, leading to confusion among users seeking more information.
After:

The popup now features clickable links that correctly navigate users to the Terms of Service and Privacy Policy pages. Users can seamlessly access these critical documents, enhancing user experience and transparency.
Checklist
Add X in the box to specify.
I have performed a self-review of my code.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.
Additional Context
The main challenge faced was ensuring the links within the popup correctly referenced the appropriate HTML pages without disrupting existing functionality. Careful attention was given to maintain the styling and responsiveness of the popup while ensuring the links are user-friendly. These improvements not only provide direct access to policies but also enhance the overall user experience on the website.
PR link: #627
Thank you for reviewing my pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants